chore: implement new workflow system #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
changed the title
v-rocheleau
requested changes
Nov 20, 2023
v-rocheleau
reviewed
Nov 20, 2023
v-rocheleau
reviewed
Nov 20, 2023
| @@ -73,7 +77,7 @@ task katsu_dataset_export_vcf { | |||
| # TODO: handle pagination, i.e. if the `next` property is set, loop | |||
| # over the pages of results | |||
| metadata_url = f"~{katsu_url}/api/experimentresults?datasets={dataset_id}&file_format=vcf&page_size=10000" | |||
| response = requests.get(metadata_url, verify=False) | |||
| response = requests.get(metadata_url, verify=~{true="True" false="False" validate_ssl}) | |||
There was a problem hiding this comment.
Same for verify string arg
v-rocheleau
reviewed
Nov 20, 2023
v-rocheleau
reviewed
Nov 20, 2023
v-rocheleau
reviewed
Nov 20, 2023
v-rocheleau
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Looks good, just not sure about wdl python commands with ssl verify
https://requests.readthedocs.io/en/latest/api/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injected service/config/secret values using new code in Bento Lib / new WES; requires new Authz (0.5.0+); see bento-platform/bento#202