Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove censorship from search code for beacon #459

Merged
merged 1 commit into from
Nov 21, 2023
Merged

remove censorship from search code for beacon #459

merged 1 commit into from
Nov 21, 2023

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Nov 21, 2023

Don't apply "max query params" censorship to search code for beacon; beacon handles its own censorship.

davidlougheed
davidlougheed approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; I'm assuming that Beacon itself also checks the threshold, rather than relying on Katsu to do the censorship?

@gsfk
Copy link
Member Author

gsfk commented Nov 21, 2023

lgtm; I'm assuming that Beacon itself also checks the threshold, rather than relying on Katsu to do the censorship?

Yes, exactly

@gsfk gsfk merged commit 9a2d73c into develop Nov 21, 2023
5 checks passed
@davidlougheed davidlougheed deleted the features/remove-beacon-query-censorship branch February 7, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @davidlougheed