Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: impose more lenient ID regex across routers/schemas #483

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

davidlougheed
Copy link
Member

This is for models which have view-sets and user-settable IDs in ingestion.

This is for models which have view-sets and user-settable IDs in ingestion.
@davidlougheed davidlougheed marked this pull request as ready for review February 7, 2024 21:25
@davidlougheed davidlougheed requested a review from gsfk February 7, 2024 21:27
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@davidlougheed davidlougheed merged commit e9002f5 into develop Feb 8, 2024
5 checks passed
@davidlougheed davidlougheed deleted the chore/id-patterns branch February 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants