Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact!: derived experiment result ingestion changes #494

Merged
merged 14 commits into from
Apr 4, 2024

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed commented Mar 22, 2024

also fixes the codecov CI stuff.

@davidlougheed davidlougheed changed the title [WIP] refact: remove dummy derived experiment result ingest workflow refact: remove dummy derived experiment result ingest workflow Mar 25, 2024
@davidlougheed davidlougheed marked this pull request as ready for review March 25, 2024 17:37
…ved-experiment-results

# Conflicts:
#	chord_metadata_service/chord/tests/test_ingest.py
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test request, otherwise lgtm!

chord_metadata_service/chord/urls.py Show resolved Hide resolved
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@b444f42). Click here to learn what that means.

Files Patch % Lines
chord_metadata_service/chord/ingest/views.py 80.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #494   +/-   ##
==========================================
  Coverage           ?   87.70%           
==========================================
  Files              ?      116           
  Lines              ?     4467           
  Branches           ?      672           
==========================================
  Hits               ?     3918           
  Misses             ?      393           
  Partials           ?      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlougheed davidlougheed changed the title refact: remove dummy derived experiment result ingest workflow refact!: derived experiment result ingestion changes Apr 3, 2024
@davidlougheed davidlougheed merged commit a1a7305 into develop Apr 4, 2024
7 checks passed
@davidlougheed davidlougheed deleted the refact/ingest-derived-experiment-results branch April 4, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants