-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: json fields charts and search #498
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #498 +/- ##
===========================================
+ Coverage 88.10% 88.25% +0.15%
===========================================
Files 128 128
Lines 4572 4632 +60
Branches 671 683 +12
===========================================
+ Hits 4028 4088 +60
Misses 390 390
Partials 154 154 ☔ View full report in Codecov by Sentry. |
this will need to be reconciled with #496 which moves a lot of functions around |
@v-rocheleau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Allows the use of JSONField with array values for public charts and search.
String field props
mapping : must end at the JSONField's name
group_by (NEW) : mapping-like path pointing to the element key within the JSONField
Number field props
mapping : must end at the JSONField's name
group_by (NEW) : mapping-like path pointing to the element key within the JSONField
group_by_value (NEW) : value to perform grouping on (e.g. only get measurements where assay/id is equal to "NCIT:C200479")
value_mapping (NEW) : mapping-like path pointing to the number key for elements of the JSONField
Example fields config