Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: individual vital_status as fk #507

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Apr 25, 2024

Allow re-use of VitalStatus for individuals with a vital_status that only has the status field.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (5c8c37c) to head (7044264).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #507   +/-   ##
========================================
  Coverage    88.27%   88.27%           
========================================
  Files          128      128           
  Lines         4640     4640           
  Branches       684      684           
========================================
  Hits          4096     4096           
  Misses         390      390           
  Partials       154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'm assuming ingestion correctly deduplicates these?

Copy link
Contributor

@noctillion noctillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ir works well! lgtm

@v-rocheleau
Copy link
Contributor Author

lgtm. I'm assuming ingestion correctly deduplicates these?

Yes, the previous VitalStatus PR has the deduplication logic but it didn't work with a one-to-one relationship.

@v-rocheleau v-rocheleau merged commit df82e8a into develop Apr 26, 2024
7 checks passed
@v-rocheleau v-rocheleau deleted the fix/individual-vitals branch April 26, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants