Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: biosamples search total count #523

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Jul 17, 2024

Fixes the discrepancy in biosample counts between public-search and beacon.

  • compute total count with all categories, even those with missing values or below threshold
  • return stats_list containing only the categories that respect the threshold.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (5848709) to head (00cf6e7).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
+ Coverage    88.55%   88.58%   +0.03%     
===========================================
  Files          131      131              
  Lines         4822     4820       -2     
  Branches       714      713       -1     
===========================================
  Hits          4270     4270              
+ Misses         396      395       -1     
+ Partials       156      155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • bump version to 8.0.1 so we can release right away
  • eventually a test might be nice here, but for now we should focus on getting v16 out

chord_metadata_service/discovery/stats.py Outdated Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - this does make some small cells a bit more obvious; another argument for future quantization maybe.

@v-rocheleau v-rocheleau merged commit 7391fcb into develop Jul 17, 2024
7 checks passed
@v-rocheleau v-rocheleau deleted the fix/biosample-search-counts branch July 17, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants