Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong search count for some searches across nested properties #551

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (51de9e8) to head (e6b15ce).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #551   +/-   ##
========================================
  Coverage    90.90%   90.90%           
========================================
  Files          127      127           
  Lines         4895     4895           
  Branches       689      689           
========================================
  Hits          4450     4450           
  Misses         299      299           
  Partials       146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@davidlougheed davidlougheed merged commit e93107f into develop Oct 31, 2024
7 checks passed
@davidlougheed davidlougheed deleted the fix/wrong-search-counts branch October 31, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants