Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable itest on Windows #1507

Closed
wants to merge 1 commit into from
Closed

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Mar 16, 2021

To solve #1506

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@bojiang bojiang changed the title Enable itest for Windows Enable itest on Windows Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1507 (18be32d) into master (0c13f5f) will decrease coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
- Coverage   69.33%   68.42%   -0.92%     
==========================================
  Files         151      151              
  Lines       10114    10114              
==========================================
- Hits         7013     6920      -93     
- Misses       3101     3194      +93     
Impacted Files Coverage Δ
bentoml/frameworks/transformers.py 0.00% <0.00%> (-76.25%) ⬇️
bentoml/frameworks/pytorch.py 55.10% <0.00%> (-28.58%) ⬇️
bentoml/marshal/marshal.py 73.05% <0.00%> (-1.20%) ⬇️
bentoml/service/__init__.py 74.83% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c13f5f...18be32d. Read the comment docs.

@bojiang
Copy link
Member Author

bojiang commented Mar 16, 2021

docker:

image operating system "linux" cannot be used on this platform

see: actions/runner-images#1143

closing

@bojiang bojiang closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant