-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): implement otlp monitoring exporter #3257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojiang
changed the title
feat(sdk): implement otlp monitor
feat(sdk): implement otlp monitoring exporter
Nov 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
- Coverage 33.93% 33.61% -0.32%
==========================================
Files 96 97 +1
Lines 9015 9099 +84
Branches 1521 1532 +11
==========================================
Hits 3059 3059
- Misses 5721 5805 +84
Partials 235 235
|
aarnphm
reviewed
Nov 17, 2022
Another thing can you also add the additional dependency to Line 441 in bd547bc
|
Also remember to add |
aarnphm
approved these changes
Nov 18, 2022
aarnphm
reviewed
Nov 18, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now bentoml monitoring can work with any collection libs that support otlp