Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): implement otlp monitoring exporter #3257

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Nov 17, 2022

Now bentoml monitoring can work with any collection libs that support otlp

@bojiang bojiang changed the title feat(sdk): implement otlp monitor feat(sdk): implement otlp monitoring exporter Nov 17, 2022
@bojiang bojiang marked this pull request as ready for review November 17, 2022 03:20
@bojiang bojiang requested a review from a team as a code owner November 17, 2022 03:20
@bojiang bojiang requested review from jjmachan and removed request for a team November 17, 2022 03:20
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #3257 (c747d63) into main (bd547bc) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
- Coverage   33.93%   33.61%   -0.32%     
==========================================
  Files          96       97       +1     
  Lines        9015     9099      +84     
  Branches     1521     1532      +11     
==========================================
  Hits         3059     3059              
- Misses       5721     5805      +84     
  Partials      235      235              
Impacted Files Coverage Δ
src/bentoml/_internal/monitoring/api.py 35.89% <0.00%> (-0.95%) ⬇️
src/bentoml/_internal/monitoring/otlp.py 0.00% <0.00%> (ø)

pyproject.toml Outdated Show resolved Hide resolved
src/bentoml/_internal/monitoring/api.py Show resolved Hide resolved
src/bentoml/_internal/monitoring/otlp.py Show resolved Hide resolved
@aarnphm
Copy link
Contributor

aarnphm commented Nov 17, 2022

Another thing can you also add the additional dependency to --extra-requires, which is defined here

FEATURES = [
?

@aarnphm
Copy link
Contributor

aarnphm commented Nov 17, 2022

Also remember to add monitoring-otlp to all as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants