-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dispatcher): prevent possible dispatcher bad behavior #3646
Open
sauyon
wants to merge
1
commit into
bentoml:main
Choose a base branch
from
sauyon:dispatcher-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
requested review from
larme,
bojiang,
a team and
aarnphm
and removed request for
a team
March 9, 2023 04:13
Codecov Report
@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
+ Coverage 31.74% 31.89% +0.14%
==========================================
Files 149 149
Lines 12149 12094 -55
Branches 2001 1984 -17
==========================================
Hits 3857 3857
+ Misses 8008 7953 -55
Partials 284 284
|
sauyon
force-pushed
the
dispatcher-fix
branch
2 times, most recently
from
March 9, 2023 04:31
576f2ec
to
cb82296
Compare
larme
reviewed
Mar 13, 2023
@sauyon Is this ready? Maybe let's discuss tomorrow so that we can merge this and another related PR, shall we? |
Sounds good, when do you want to chat? |
bojiang
added
the
pr/merge-hold
Requires further discussions before a pull request can be merged
label
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible that if request load was fast enough and max latency set low enough, the dispatcher would enter a loop of waiting for new requests while cancelling the oldest ones while doing no work, this change seeks to fix that.