Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Document For Example #3876

Merged
merged 4 commits into from
Jul 4, 2023
Merged

docs: Update Document For Example #3876

merged 4 commits into from
Jul 4, 2023

Conversation

khanh41
Copy link
Contributor

@khanh41 khanh41 commented May 20, 2023

Update documentation

  • Add </table> to examples/custom_runner/nltk_pretrained_model/README.md
  • Update right input of example : https://docs.bentoml.org/en/latest/concepts/service.html#json
  • Update document for clearly and remove not have parameters: https://docs.bentoml.org/en/latest/concepts/service.html#composite-types

@khanh41 khanh41 requested a review from a team as a code owner May 20, 2023 10:03
@khanh41 khanh41 requested review from larme and removed request for a team May 20, 2023 10:03
aarnphm
aarnphm requested changes May 20, 2023
View reviewed changes
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny comment

docs/source/concepts/service.rst Show resolved Hide resolved
aarnphm
aarnphm previously approved these changes Jul 4, 2023
View reviewed changes
@aarnphm aarnphm merged commit 33c8440 into bentoml:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@larme larme Awaiting requested review from larme larme is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khanh41 @aarnphm @khanhtv-nal