Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add response headers for error responses #4622

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming me@frostming.com

What does this PR address?

Fixes #(issue)

Before submitting:

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming requested a review from a team as a code owner March 29, 2024 07:03
@frostming frostming requested review from larme and removed request for a team March 29, 2024 07:03
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like to me as a refactor

@frostming frostming merged commit 3e1cd6c into bentoml:main Apr 1, 2024
40 of 42 checks passed
@frostming frostming deleted the fix/response-header branch April 1, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants