Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: init io-descriptors example #4646

Merged
merged 3 commits into from
Apr 29, 2024
Merged

docs: init io-descriptors example #4646

merged 3 commits into from
Apr 29, 2024

Conversation

lycheel1
Copy link
Collaborator

@lycheel1 lycheel1 commented Apr 10, 2024

What does this PR address?

Fixes #(issue)

Before submitting:

@lycheel1 lycheel1 requested a review from a team as a code owner April 10, 2024 21:08
@lycheel1 lycheel1 requested review from sauyon, larme and Sherlock113 and removed request for a team April 10, 2024 21:08
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lycheel1 some minor changes needed

@Sherlock113 when you have time, could you review the readme part? Thanks

examples/io-descriptors/service.py Outdated Show resolved Hide resolved
examples/io-descriptors/service.py Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
examples/io-descriptors/README.md Outdated Show resolved Hide resolved
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes will be another pr

@larme larme merged commit 020552d into main Apr 29, 2024
40 of 43 checks passed
@larme larme deleted the docs/io-descriptors branch April 29, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants