feat(monitoring): support GRPC LogExporter #4808

judahrand · 2024-06-15T14:45:44Z

What does this PR address?

Fixes #(issue)

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

src/bentoml/_internal/monitoring/otlp.py

aarnphm

With the deps check, other wise this LGTM.

aarnphm

LGTM. Thanks.

feat(monitoring): support GRPC LogExporter

b2b753a

judahrand requested a review from a team as a code owner June 15, 2024 14:45

judahrand requested review from jianshen92 and removed request for a team June 15, 2024 14:45

judahrand mentioned this pull request Jun 15, 2024

fix(monitoring): don't override user set environment variables #4807

Open

5 tasks

aarnphm reviewed Jun 17, 2024

View reviewed changes

src/bentoml/_internal/monitoring/otlp.py Show resolved Hide resolved

aarnphm approved these changes Jun 17, 2024

View reviewed changes

Add dependency to monitor-otlp

86a50fc

judahrand requested a review from aarnphm June 17, 2024 08:57

Pass through credentials

005c7aa

aarnphm approved these changes Jun 17, 2024

View reviewed changes

aarnphm merged commit e1efdc6 into bentoml:main Jun 17, 2024
40 of 42 checks passed