Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(decorator): reject wrapper as dunder methods #5030

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(decorator): reject wrapper as dunder methods #5030

merged 1 commit into from
Oct 17, 2024

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Oct 16, 2024

Reject wrapper for @api and @task to wrap dunder methods

@aarnphm
fix(decorator): gated wrapper to not support dunder methods
ddcb03e 
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
@aarnphm aarnphm requested a review from a team as a code owner October 16, 2024 23:55
@aarnphm aarnphm requested review from jianshen92 and frostming and removed request for a team October 16, 2024 23:55
@github-actions GitHub Actions
Copy link

Code Coverage

Package Statements
bentoml 55.47% (9808 / 17681)
Summary 55.47% (9808 / 17681)

@frostming frostming merged commit b696903 into main Oct 17, 2024
49 of 51 checks passed
@frostming frostming deleted the fix/gated-special-functions-api branch October 17, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssheng ssheng ssheng approved these changes

@jianshen92 jianshen92 Awaiting requested review from jianshen92 jianshen92 is a code owner automatically assigned from bentoml/bentoml-reviewers

@frostming frostming Awaiting requested review from frostming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarnphm @ssheng @frostming