Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving CLI - implement label filter for list deployments #521

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

yubozhao
Copy link
Contributor

(Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below.)

What changes were proposed in this pull request?

Does this close any currently open issues?

How was this patch tested?

@yubozhao yubozhao changed the title Improving CLI - implem Improving CLI - implement label filter for list deployments Feb 10, 2020
@yubozhao yubozhao requested a review from parano February 10, 2020 22:11
@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@11ae828). Click here to learn what that means.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #521   +/-   ##
=========================================
  Coverage          ?   56.22%           
=========================================
  Files             ?       89           
  Lines             ?     6440           
  Branches          ?        0           
=========================================
  Hits              ?     3621           
  Misses            ?     2819           
  Partials          ?        0
Impacted Files Coverage Δ
bentoml/cli/deployment.py 36% <ø> (ø)
bentoml/yatai/yatai_service_impl.py 35.18% <ø> (ø)
bentoml/cli/aws_lambda.py 37.59% <ø> (ø)
bentoml/yatai/client/deployment_api.py 17.72% <ø> (ø)
bentoml/cli/aws_sagemaker.py 40.14% <ø> (ø)
bentoml/proto/deployment_pb2.py 100% <ø> (ø)
bentoml/cli/click_utils.py 59.15% <10.52%> (ø)
bentoml/deployment/store.py 37.14% <12.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ae828...d50b620. Read the comment docs.

@yubozhao yubozhao requested a review from parano February 10, 2020 23:34
@parano parano merged commit 5c771ca into bentoml:master Feb 10, 2020
bojiang pushed a commit to bojiang/BentoML that referenced this pull request Feb 13, 2020
)

* implement label filter for list deployment

* update base on comment
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
)

* implement label filter for list deployment

* update base on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants