sagemaker deployment - handle endpoint not found for sagemaker delete #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubozhao
changed the title
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
=========================================
Coverage ? 56.41%
=========================================
Files ? 89
Lines ? 6434
Branches ? 0
=========================================
Hits ? 3630
Misses ? 2804
Partials ? 0
Continue to review full report at Codecov.
|
parano
reviewed
Feb 10, 2020
| not error_code == 'ValidationException' | ||
| or 'Could not find endpoint' not in error_message | ||
| ): | ||
| raise _aws_client_error_to_bentoml_exception(e) | ||
|
|
||
| _try_clean_up_sagemaker_deployment_resource(deployment_pb) |
There was a problem hiding this comment.
as discussed offline, let's add function delete_sagemaker_endpoint_if_exist, and call this function in _try_clean_up_sagemaker_deployment_resource.
rename _try_clean_up_sagemaker_deployment_resource to _delete_sagemaker_deployment_resource_if_exist
parano
approved these changes
Feb 11, 2020
bojiang
pushed a commit
to bojiang/BentoML
that referenced
this pull request
Feb 13, 2020
…bentoml#522) * handle endpoint not exist for sagemaker delete * include delete endpoint in clean up function * update sagemaker moto
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
…bentoml#522) * handle endpoint not exist for sagemaker delete * include delete endpoint in clean up function * update sagemaker moto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #504