Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] rename handler to adapter #789

Merged
merged 4 commits into from
Jun 14, 2020
Merged

[Doc] rename handler to adapter #789

merged 4 commits into from
Jun 14, 2020

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Jun 12, 2020

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation
  • Test, CI, or build
  • None

Components (if applicable)

  • BentoService (model packaging, dependency management, handler definition)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, logging, metrics, tracing, benchmark, OpenAPI)
  • YataiService (model management, deployment automation)
  • Documentation

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change in bentoml/gallery example notebooks
  • I have sent a pull request to bentoml/gallery to make that change

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #789 into master will decrease coverage by 0.45%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
- Coverage   55.53%   55.07%   -0.46%     
==========================================
  Files         108      114       +6     
  Lines        8144     8241      +97     
==========================================
+ Hits         4523     4539      +16     
- Misses       3621     3702      +81     
Impacted Files Coverage Δ
bentoml/__init__.py 100.00% <ø> (ø)
bentoml/adapters/pytorch_tensor_input.py 0.00% <0.00%> (ø)
bentoml/artifact/fastai_model_artifact.py 43.58% <ø> (-1.42%) ⬇️
bentoml/artifact/fasttext_model_artifact.py 41.37% <ø> (-1.96%) ⬇️
bentoml/artifact/h2o_model_artifact.py 39.39% <ø> (-1.79%) ⬇️
bentoml/artifact/keras_model_artifact.py 20.47% <ø> (-0.63%) ⬇️
bentoml/artifact/lightgbm_model_artifact.py 38.23% <ø> (-1.77%) ⬇️
bentoml/artifact/onnx_model_artifact.py 84.93% <ø> (-0.21%) ⬇️
bentoml/artifact/pytorch_model_artifact.py 85.00% <ø> (-0.37%) ⬇️
bentoml/artifact/sklearn_model_artifact.py 70.00% <ø> (-0.74%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a134e3a...a6b1fe1. Read the comment docs.

@parano parano merged commit 75e9c44 into bentoml:master Jun 14, 2020
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* [Doc] add deprecated warning for handlers

* [Doc] rename handler to adapter

* [Fix] wrap class

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants