Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] DataFrameInput supports json input with orient="records" #809

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Jun 17, 2020

TODO:

  • orient="index"
  • orient="split"
  • configurable orient

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation
  • Test, CI, or build
  • None

Components (if applicable)

  • BentoService (model packaging, dependency management, handler definition)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, logging, metrics, tracing, benchmark, OpenAPI)
  • YataiService (model management, deployment automation)
  • Documentation

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change in bentoml/gallery example notebooks
  • I have sent a pull request to bentoml/gallery to make that change

@pep8speaks
Copy link

pep8speaks commented Jun 17, 2020

Hello @bojiang, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2020-06-17 09:10:52 UTC

@bojiang bojiang changed the title [FIX] support records orient in DataFrameInput.handle_batch_request [FIX] support input orient=records in batch mode of DataFrameInput Jun 17, 2020
@bojiang bojiang changed the title [FIX] support input orient=records in batch mode of DataFrameInput [FIX] DataFrameInput supports json input with orient="records" Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #809 into master will increase coverage by 0.07%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   55.90%   55.98%   +0.07%     
==========================================
  Files         115      115              
  Lines        8425     8442      +17     
==========================================
+ Hits         4710     4726      +16     
- Misses       3715     3716       +1     
Impacted Files Coverage Δ
bentoml/adapters/dataframe_input.py 81.18% <87.50%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1c5d4...e56eace. Read the comment docs.

@bojiang bojiang linked an issue Jun 17, 2020 that may be closed by this pull request
@parano parano merged commit 897d562 into bentoml:master Jun 18, 2020
@bojiang bojiang deleted the dev branch June 18, 2020 05:42
@bojiang bojiang linked an issue Jun 18, 2020 that may be closed by this pull request
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants