Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a smaller page limit for bentoml list #887

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

parano
Copy link
Member

@parano parano commented Jul 12, 2020

Description

The default value for list is currently set to 200, which makes the bentoml list very slow for users that have lots of BentoML bundles created. This PR changes this default to 40.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #887 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   61.82%   61.81%   -0.01%     
==========================================
  Files         120      120              
  Lines        7918     7922       +4     
==========================================
+ Hits         4895     4897       +2     
- Misses       3023     3025       +2     
Impacted Files Coverage Δ
bentoml/yatai/repository/metadata_store.py 66.35% <50.00%> (+0.31%) ⬆️
bentoml/utils/dataframe_util.py 89.90% <0.00%> (-0.49%) ⬇️
bentoml/service.py 85.66% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee7be5...20c0d1c. Read the comment docs.

@parano parano merged commit b6672b5 into bentoml:master Jul 12, 2020
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant