Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart shows both 23:00 and 00:00 timestamps for dates occuring after DST-boundary change #108

Closed
benvinegar opened this issue Nov 10, 2024 · 2 comments
Closed

Chart shows both 23:00 and 00:00 timestamps for dates occuring after DST-boundary change #108

benvinegar opened this issue Nov 10, 2024 · 2 comments

Comments

@benvinegar
Copy link
Owner

Since daylight savings came into effect here, I notice that this chart is showing this saw-tooth graph, where each day has 2 data points. The proper data point is at 00:00, and the zero data point is at 23:00. This has repeated for each day.

image
@benvinegar
Copy link
Owner Author

I notice this is occurring only in my production instance of Counterscale (counterscale.dev), and not locally.

I'm guessing these are more TZ-related issues like #107 that are caused by the server guessing the timezone (from Cloudflare headers).

@benvinegar benvinegar mentioned this issue Nov 10, 2024
Closed
@benvinegar benvinegar changed the title Issue where server returns both 23:00 and 00:00 timestamps post-DST change Chart shows both 23:00 and 00:00 timestamps for dates occuring after DST-boundary change Nov 16, 2024
benvinegar added a commit that referenced this issue Nov 16, 2024
@benvinegar
Fix DST boundary issue occurring on Cloudflare env (fixes #108)
e01be48
@benvinegar benvinegar mentioned this issue Nov 16, 2024
Merged
@benvinegar
Copy link
Owner Author

Before fix (notice the sawtooth pattern):

image

After fix:

image

benvinegar added a commit that referenced this issue Dec 20, 2024
@benvinegar
Fix DST boundary issue occurring on Cloudflare env (fixes #108) (#114)
5c4ed8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benvinegar