Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved dashboard error msgs when credentials missing #113

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

benvinegar
Copy link
Owner

@benvinegar benvinegar commented Nov 16, 2024

Now when Counterscale is misconfigured, you get a far more human-readable error experience.

This PR also upgrades Vitest from 1.x to 2.x.

Before (v embarrassing):

image

After:

image

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.89%. Comparing base (0a19c38) to head (cf9fb9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/routes/dashboard.tsx 43.47% 13 Missing ⚠️
app/root.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   77.66%   72.89%   -4.77%     
==========================================
  Files          31       32       +1     
  Lines        3138     2225     -913     
  Branches      217      219       +2     
==========================================
- Hits         2437     1622     -815     
+ Misses        693      595      -98     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit 5ae04f2 into main Nov 16, 2024
3 checks passed
@benvinegar benvinegar deleted the better-error-msg branch December 13, 2024 18:38
benvinegar added a commit that referenced this pull request Dec 20, 2024
* Fix dashboard error message when credentials are invalid

* Update vitest coverage deps to 2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant