Removed const modifier for color variable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The const modifier on the float4 color definition at line 295 seems to cause problems with Intel GPUs. I removed that modifier (I have NO idea if this is a bad thing to do) and the kernel now compiles on both Nvidia and Intel GPUs. This means that the ClearVolume FIJI plugin can now work on Intel GPUs, whereas it would crash otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The const modifier on the float4 color definition at line 295 seems to cause problems with Intel GPUs. I removed that modifier (I have NO idea if this is a bad thing to do) and the kernel now compiles on both Nvidia and Intel GPUs. This means that the ClearVolume FIJI plugin can now work on Intel GPUs, whereas it would crash otherwise.
I am not a java programmer, nor do I know anything about OpenCL development. I don't know if this was a "safe" change. I just wanted to be able to use the ClearVolume plugin on my laptop, and this seemed to work!