Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nimbus as EL in kurtosis #1323

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

add nimbus as EL in kurtosis #1323

wants to merge 6 commits into from

Conversation

nidhi-singh02
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 commented Jun 5, 2024

Getting error in CL. beaconkit is able to connect to the nimbus EL client, but unable to build block.

Screenshot 2024-06-06 at 9 46 06 PM

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.55%. Comparing base (511aefd) to head (7ee48f7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   21.55%   21.55%           
=======================================
  Files         353      353           
  Lines       15997    15997           
  Branches       21       21           
=======================================
  Hits         3448     3448           
  Misses      12433    12433           
  Partials      116      116           

@itsdevbear itsdevbear force-pushed the main branch 2 times, most recently from 1873625 to d1b6981 Compare June 7, 2024 00:16
@itsdevbear
Copy link
Member

@nidhi-singh02 try changing chain ID

@nidhi-singh02
Copy link
Contributor Author

@nidhi-singh02 try changing chain ID

Yeah, It is getting picked from testing/files/eth-genesis.json. I see few errors in the logs but the height is updating now.

Copy link
Contributor

coderabbitai bot commented Jun 14, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@itsdevbear
Copy link
Member

@nidhi-singh02 is this working now?

@nidhi-singh02
Copy link
Contributor Author

@nidhi-singh02 is this working now?

I could see the block height is increasing which was not the case earlier, but there's error for nil payload ID, not sure if it is issue at our end or the nimbus.

@itsdevbear
Copy link
Member

yeah means its not building blocks, though unclear if nimbus even supports this yet :P

@nidhi-singh02
Copy link
Contributor Author

Yeah! I checked with the nimbus team, it seems their engine API is undergoing fix.
Screenshot 2024-06-14 at 7 55 52 PM

Wanted to rule out the possibility that it is not issue at our end. :) Fun part is the same docker image is being used in kurtosis ethereum package.

Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Copy link
Contributor Author

@nidhi-singh02 nidhi-singh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried running it today, facing same issue - block building is failing, I have asked nimbus team reg the DB migration and the engine API. @itsdevbear

Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants