-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all): update cosmos-sdk deps #2221
Merged
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8036884
wip: pointing to local repo
abi87 c793ad1
Merge branch 'main' into replace-berachain-cosmos-sdk-point-local-repo-2
abi87 2bf2204
go mod tidy
abi87 b1ca464
Merge branch 'main' into replace-berachain-cosmos-sdk-point-local-repo-2
abi87 0f8c329
updated go.mod to use local cometbft
alesforz 8b9c92e
Fixed bug in which the BLS12-381 compressed key was created incorrectly.
alesforz bf43e1a
updated go.mod with cometbft version
alesforz aa66559
updated version of cometbft
alesforz 9f049f6
updated cosmos-sdk api module version
alesforz 51ce9b0
updated cosmos-sdk core module version
alesforz 64ba462
updated cosmos-sdk core/testing module version
alesforz 53aa9e9
updated cosmos-sdk x/account module version
alesforz e32add8
updated cosmos-sdk x/bank module version
alesforz aab6242
updated cosmos-sdk x/staking module version
alesforz 12a2686
updated cosmos-sdk module version
alesforz 6183fad
Substituted use of module `/store/v2` with module `cosmos-db`
alesforz 09f3034
updated go.mod to remove /store/v2 dependency
alesforz 7830414
removed commented out lines in go.mod
alesforz 4025e37
pinned cometbft version in go.mod
alesforz 87616fc
removed commented out lines in node-core/components/deposit_store.go
alesforz 699fe17
updated go version in the CI pipeline
alesforz 19a0ab0
Merge branch 'main' into replace-berachain-cosmos-sdk-point-local-repo-2
abi87 2596435
updated go.mod to latest cometbft version
alesforz f0b9432
Merge pull request #2302 from informalsystems/alesforz/fix-bls-key-len
fridrik01 706c91e
Fix linter errors on cosmos-sdk upgrade branch (#2303)
fridrik01 8fa9c59
Merge branch 'main' into replace-berachain-cosmos-sdk-point-local-repo-2
abi87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abi87 What was the motivation for adding this check? Is this related to the dep updated or just wanting to prevent footguns and ensure >=1s block times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Immediate tests following dep updates showed a large number of consensus blocks produced pretty rapidly. We realized some of configs were not properly handled (wrongly picking cometBFT default values instead of BeaconKit) and we added this check as a fail fast kind of solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the context - this is very helpful!