refactor(engine): improve Engine.Start error handling #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
reviewed
Jan 2, 2025
| return nil | ||
|
|
||
| select { | ||
| case err := <-errChan: |
There was a problem hiding this comment.
This changes the behavior of Start. Previously, we'd exit as soon as goroutine was spawned. Now we're waiting for Start to finish (blocking select). What's the point of having a goroutine then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the error handling in the
Engine.Startmethod. The current implementation usespanicto handle errors, which could lead to program crashes and makes error handling difficult for upstream callers.Changes
panicwith proper error handling using channels