-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull groups from datahub into other hubs #3520
Comments
The hubs that do use CanvasOAuthenticator are getting that via |
@ryanlovett so if we move everything except datahub to genericoauthenticator, and provide groups in canvasoauthenticator, then all the hubs using genericoauthenticator can get list of groups from datahub! |
@yuvipanda and I slacked and he said that the idea was for datahub to be canvasoauth, the others genericoauth. The others could query the groups from datahub.berkeley.edu/hub/api/user presumably during spawning in order to do resource allocation. I could confirm that using a token to GET /hub/api/user from my laptop does have the user's groups in the output. Some questions for @yuvipanda :
|
@ryanlovett Is this issue in scope for the August sprint? or it should be scoped in the backlog? Trying to move around the cards and identify the right spot mirroring its current status. |
@balajialg It could be. A lot of the work is done but I need to get @yuvipanda 's thoughts on the questions above. |
@ryanlovett Sounds good. Thanks! |
After chatting with @yuvipanda:
Edit: 2022-11-03: This is no longer the case. See below. |
Also set manage_groups in hub/values.
Convert canvas oauth hubs to generic for #3520.
reference for canvsoauth PR: jupyterhub/oauthenticator#406 |
After today's meeting, it was suggested that it would be easier for most hubs to just use CanvasAuthenticator and not GenericOAuthenticator. So instead of the genericoauth hubs pulling group data from datahub, they will get it by virtue of using canvasauth. This greatly simplifies the configurations of all the non-datahub datahubs. The tradeoff is that the hub URLs must be entered into the Canvas (bCourses) configuration. @felder will make this happen in the short term (directly, or through the local Canvas lead). It may be possible to enable @shaneknapp to either request such changes in the future or make them directly as @felder is permitted. |
Bug description
The following hubs use GenericOAuthenticator, with configuration for bCourses:
astro, data8, ischool, publichealth, stat159, stat20
While these hubs use CanvasOAuthenticator:
biology, data100, data102, datahub, dlab, eecs, julia, prob140
A small number of other deployments use dummy, google, and lti auth.
The cookiecutter template is set to use generic as well.
When we enable groups within CanvasOauthenticator, the generic-based hubs will not receive this feature. I don't think there is any loss of functionality in moving all GenericOAuthenticator-based hubs (and the cookiecutter template) with login_service of
bCourses
to CanvasOAuthenticator.Thoughts? My feeling is that if we do this, we should do it at least a couple weeks before Fall.
Environment & setup
Tasks to be done
Hub which needs to get moved to canvas auth
The text was updated successfully, but these errors were encountered: