Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add server spawn delay #4241

Merged
merged 4 commits into from
Feb 13, 2023
Merged

add server spawn delay #4241

merged 4 commits into from
Feb 13, 2023

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Feb 9, 2023 •
edited
Loading

@shaneknapp shaneknapp mentioned this pull request Feb 9, 2023
Closed
felder
felder reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@felder felder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this in staging via hubploy first?

@shaneknapp
Copy link
Contributor Author

Were you able to test this in staging via hubploy first?

yep, only a11y-staging has this new "feature" deployed.

@shaneknapp shaneknapp mentioned this pull request Feb 13, 2023
Closed
@shaneknapp
Copy link
Contributor Author

ok, this works and has already shown itself to be useful! will be merging to staging now.

@shaneknapp shaneknapp merged commit eb38930 into berkeley-dsep-infra:staging Feb 13, 2023
ryanlovett added a commit that referenced this pull request Feb 14, 2023
@ryanlovett
Merge pull request #4254 from berkeley-dsep-infra/staging
b65f6b3 
Merge #4241, #4253.
@shaneknapp shaneknapp deleted the add-server-launch-delay-timer branch April 28, 2023 18:26
@shaneknapp shaneknapp mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felder felder felder left review comments

@ryanlovett ryanlovett ryanlovett left review comments

@balajialg balajialg Awaiting requested review from balajialg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaneknapp @felder @ryanlovett