Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force downgrade nbconvert #506

Closed
wants to merge 1 commit into from

Conversation

dibyaghosh
Copy link
Contributor

No description provided.

@yuvipanda
Copy link
Contributor

Heya! Can you gimme some reasons for why you'd want to do this?

nbconvert 4.x is incompatible with the version of notebook we are running, and will cause starting user servers to fail. See berkeley-dsep-infra/data100-19s#59 where we tried something like this with data100 and failed.

@dibyaghosh
Copy link
Contributor Author

Hey!

nbconvert 4.x is the last versions of nbconvert in which converting notebooks to PDFs displays errors when the Latex fails to compile instead of silently aborting the compilation, and having a half-rendered PDF that includes no cell beyond the one with failed LaTex.

As 140's grading pipeline involves students exporting their notebooks to PDFs, it's rather critical that students be made aware when their submission isn't full. I'm not aware of any way to enable this behavior in nbconvert >= 5.

@yuvipanda
Copy link
Contributor

@dibyaghosh there seems to be no way to use nbconvert < 5 with the current version of notebook we have either. We might have to try going back notebook versions slowly to see if any version works.

In the meantime, @ryanlovett is trying to fix this in nbconvert jupyter/nbconvert#947

@dibyaghosh
Copy link
Contributor Author

Got it! Thanks for checking up on this - as for compatibility between nbconvert and notebook, I know we successfully ran nbconvert @ 4.3.0 in Spring 2017, so if we can find the config file there, we can probably find a compatible version. https://github.com/data-8/jupyterhub-k8s/tree/a1234b23588ba91509c366c6c442d8ca1f799e32/user

This was the repo used back then, but it doesn't seem that a version of notebook is specified? I haven't looked too carefully...

@ryanlovett
Copy link
Collaborator

Fixed by 07f5088 and a7ce882.

@ryanlovett ryanlovett closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants