Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-400] remove shiny hub #6863

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

felder
Copy link
Contributor

@felder felder commented Mar 7, 2025

@felder felder requested a review from balajialg March 7, 2025 21:32
@github-actions github-actions bot added documentation Issues around adding and modifying docs build-infra configuration hub: shiny labels Mar 7, 2025
@felder felder requested a review from yijunge-ucb March 7, 2025 21:32
@felder
Copy link
Contributor Author

felder commented Mar 7, 2025

This is ready to go, I just want more eyes on it first. If it looks ok, please merge it. It'd probably also make sense to immediately submit and merge PR to send this to prod as well.

@felder felder requested a review from ryanlovett March 7, 2025 21:50
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

You can also remove the file docs/hubs/shiny.qmd. I think shiny also needs to be removed from scripts/user-image-management/repos.txt. Lastly, it worth swapping out shiny for something else in the examples in docs/tasks/user-images/transition-image.qmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-infra configuration documentation Issues around adding and modifying docs hub: shiny
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants