[DH-301] use this as the default image config, swiped from nature hub

[shaneknapp]

@felder

[felder]

The list of default packages is not necessarily complete, we should think about if we want/need anything else in there. I also suggested items to remove from environment.yaml, also shouldn't it be named environment.yml? not environment.yaml?

[felder]

@shaneknapp this PR is missing some of the required packages that were listed in the other one.

Can you make environment.yaml look like this?

name: default-datahub-user-image
# This is the standard conda configuration file. Use this file to list
# the conda packages that you need installed in your environment.
channels:
- conda-forge

dependencies:

# Items required for basic level functionality
- gh-scoped-creds==4.1
- git==2.46.0
- jupyter-resource-usage==1.1.0
- jupyter_server==2.14.2
- jupyterhub==4.1.6
- jupyterlab==4.2.5
- jupyterlab-git==0.50.1
- jupytext==1.16.4
- nbgitpuller==1.2.1
- notebook==7.2.2
- python==3.11.*
 
# pip installed packages, conda is prefered
- pip==24.2
- pip:
  - nbconvert[webpdf]==7.16.4

[shaneknapp]

unsure why it's not finding playwright?

Step 45/52 : RUN ./postBuild
 ---> Running in 19fd99c69af7
./postBuild: line 6: playwright: command not found

[felder]

@shaneknapp If I check this out and build locally, the issue seems to be environment.yaml vs environment.yml, immediately visible is python 3.10:

(datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ jupyter-repo2docker --version
2024.07.0
(datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ git branch
  main
* update-default-image-config
(datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ jupyter-repo2docker --user-id=1000 --user-name=jovyan --Repo2Docker.platform=linux/amd64 --target-repo-dir=/home/jovyan/.cache .
Picked Local content provider.
Using local repo ..
Python version unspecified, using current default Python version 3.10. This will change in the future.Building conda environment for python=3.10
Using PythonBuildPack builder
^C

(datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ mv environment.yaml environment.yml
(datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ jupyter-repo2docker --user-id=1000 --user-name=jovyan --Repo2Docker.platform=linux/amd64 --target-repo-dir=/home/jovyan/.cache .
Picked Local content provider.
Using local repo ..
Building conda environment for python=3.11
Using CondaBuildPack builder
...

[shaneknapp]

weird, thanks for the 2nd set of eyes.

…

On Fri, Oct 4, 2024 at 4:29 PM felder ***@***.***> wrote: @shaneknapp <https://github.com/shaneknapp> If I check this out and build locally, the issue seems to be environment.yaml vs envrinoment.yml, immediately visible is python 3.10: (datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ jupyter-repo2docker --version 2024.07.0 (datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ git branch main * update-default-image-config (datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ jupyter-repo2docker --user-id=1000 --user-name=jovyan --Repo2Docker.platform=linux/amd64 --target-repo-dir=/home/jovyan/.cache . Picked Local content provider. Using local repo .. Python version unspecified, using current default Python version 3.10. This will change in the future.Building conda environment for python=3.10 Using PythonBuildPack builder ^C (datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ mv environment.yaml environment.yml (datahub-venv) Jonathans-2021-MacBook-Pro:hub-user-image-template felder$ jupyter-repo2docker --user-id=1000 --user-name=jovyan --Repo2Docker.platform=linux/amd64 --target-repo-dir=/home/jovyan/.cache . Picked Local content provider. Using local repo .. Building conda environment for python=3.11 Using CondaBuildPack builder ... — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMIHLE7ENONH5IC44D3J4TZZ4QGTAVCNFSM6AAAAABNNE5QNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUG44DMNBSGM> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[felder]

@shaneknapp I think we should standardize on extensions for the yaml files, I really don't think we should have some of them named .yaml and others .yml so if you want .yaml maybe file an upstream bug report?

[shaneknapp]

@shaneknapp I think we should standardize on extensions for the yaml files, I really don't think we should have some of them named .yaml and others .yml

according to yaml.org (https://yaml.org/faq.html):

Is there an official extension for YAML files?

Please use ".yaml" when possible.

so this is definitely a bug in repo2docker. github actions, for instance, happily works w/either extension. i'll file a bug either this weekend or early next week.

tbh, i would much prefer to use .yaml over .yml...

[shaneknapp]

issue filed: jupyterhub/repo2docker#1373

[shaneknapp]

@felder does this look good to merge?

[felder]

@shaneknapp yeah I guess so. I just bumped git and I suppose if anything is missing it's a simple matter to update it again.

[shaneknapp]

@shaneknapp yeah I guess so. I just bumped git and I suppose if anything is missing it's a simple matter to update it again.

thanks @felder !