Skip to content

Conversation

@AboudyKreidieh
Copy link
Collaborator

prerequisite: #23

  • cleaned up examples and ensured they are all running
  • renamed two_loops_merge_straight -> loop_merge for simplicity
  • renamed TwoLoopMergeEnv -> TwoLoopMergePOEnv for consistency among examples that use the environment

changes originally approved in flow-devel

@AboudyKreidieh AboudyKreidieh mentioned this pull request Aug 10, 2018

class TwoLoopsMergeEnv(Env):
class TwoLoopsMergePOEnv(Env):
"""Environment for training cooperative merging behavior in a closed loop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify description to indicate that it is partially observed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugenevinitsky eugenevinitsky merged commit 442fe1c into master Aug 16, 2018
@eugenevinitsky eugenevinitsky deleted the examples_fix branch August 16, 2018 16:37
kjang96 pushed a commit to kjang96/flow that referenced this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants