45 address sync and consistency issues under typical load scenarios #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages from logged in users throw a JS error in the client for logged-out users because of conditional logic in the socket service which does not guard against this scenario and tries to look up a non-existent resolver. Checking if the resolver exists before using it fixes the bug.
…count updates and faster thread switching. Suports #45.
…s not scrolled to the bottom. Supports #45.
…onnection. Prevents double messages after reconnect. Supports #45.
These changes should be reversed when there is time to fix pseudonym deletion. Currently pseudonym deletion breaks the pseudonym mismatch logic and causes message sending to fail silently in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR for my work on #45.