Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to create a poll. #66

Merged
merged 27 commits into from
Nov 8, 2024
Merged

Add functionality to create a poll. #66

merged 27 commits into from
Nov 8, 2024

Conversation

katherineqian
Copy link

@katherineqian katherineqian commented Nov 2, 2024 •
edited
Loading

This PR introduces new UI and hooks up the API for creating a poll as part of the Nebula effort.

Questions for review

  • Moved to PR comments! :)

@katherineqian
Merge pull request #1 from katherineqian/nebula
a3a1882 
Sync Nebula changes from Brendan.
@katherineqian
Remove unused path throwing lint error.
7732e1f
@katherineqian
Add bg color and change text on "new space" button.
5b7eb66
@katherineqian
Fix linter errors in ThreadsPage.
5621c8c
@katherineqian
Move CreateThread to shared and rename to CreateSpace.
92b426a
@katherineqian
Remove standard body padding on Modal (prevents desired layout for Cr…
6b8bcde 
…eateSpace).
@katherineqian
Rename Modal -> ThemedModal for lint error requiring multi-word templ…
9d35fd8 
…ate names.
@katherineqian
Remove unnecessary const props usage.
edde54a
@katherineqian
Add some minor top padding to CreateChannel option buttons.
c8d19b4
@katherineqian
Fix lint error on CreateChannel.vue (unnecessary backslash in regex).
1a36ac7
@katherineqian
Add working tabs to CreateSpace dialog.
5f1685f
@katherineqian
Add description and padding to New Thread dialog.
e06a54a
@katherineqian
Change icon for Threshold Poll.
9a3edfc
@katherineqian
Factor out Create Thread form to a new component called CreateThread,…
b8d413b 
… and replicate the original functionality.
@katherineqian
Set up CreatePoll file for Create Poll tab content.
9347814
@katherineqian
Implement working CreatePoll page with title input only.
250cd99
@katherineqian
Remove unused variables and addChannel function in useStore.js throwi…
d3c8e05 
…ng errors.
@katherineqian
Implement undefined setMajorError function in useStore.js.
8ac4e5a
@katherineqian
Create new PollService and use it in useStore.js.
e4fc306
@katherineqian
Rename pollTitle to title; change validation to individual functions …
58f1621 
…to allow separate error messages.
@katherineqian
Add a description field. Remove login-form-field from inputs.
2954dd0
@katherineqian
Implement basic HTML date picker for end date.
3febefb
@katherineqian
Set dynamic default values for date picker (default to expire 5 days …
82f0b82 
…from today, min value is today).
@katherineqian
Remove unused props.
8a730b9
@katherineqian
Convert expiration date to value and pass into poll creation.
cd02c37
katherineqian
katherineqian commented Nov 4, 2024
View reviewed changes
Copy link
Author

@katherineqian katherineqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Something is crashing my VSCode due to "too many open files". I have had to restart my MongoDB server due to it. I'm not sure if it's the pre-commit linter causing this, or something else. Any thoughts on what this is? Searching the internet was not fruitful.

  • Overall would appreciate feedback on the UI refactoring and changes I've made!

src/components/Polls/CreatePoll.vue Show resolved Hide resolved
src/components/Polls/CreatePoll.vue Show resolved Hide resolved
src/service/poll.js Show resolved Hide resolved
src/components/Polls/CreatePoll.vue Outdated Show resolved Hide resolved
src/components/Polls/CreatePoll.vue Show resolved Hide resolved
@bmiller59
Copy link

bmiller59 commented Nov 4, 2024 •
edited
Loading

Overall looks great! I see you are trying to match the vernacular of the project and I do not see any general code concerns at this point. Let me know if you have any questions or want to discuss about the codebase or vue generally.

On too many files, sounds to me like this is a system resource issue. We are already excluding node_modules from linting, so that is my guess. Do you have a Mac? You can find a few things to try here: https://stackoverflow.com/questions/19981065/nodejs-error-emfile-too-many-open-files-on-mac-os

bmiller59
bmiller59 approved these changes Nov 8, 2024
View reviewed changes
Copy link

@bmiller59 bmiller59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging.

@katherineqian
Copy link
Author

katherineqian commented Nov 8, 2024 •
edited
Loading

Thanks Brendan 💃 first Nebula PR, done !! 🎶

@katherineqian katherineqian merged commit bad3b51 into berkmancenter:63-nebula-initial-mvp Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmiller59 bmiller59 bmiller59 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katherineqian @bmiller59