Fix #251: dbal driver - safe queue creation

[Ocramius]

Since we don't have UPSERT support in DBAL (and sadly will not be in it for a while), this PR fixes #251 by providing graceful handling of queue creation.

1. operations are executed in a transaction
2. only unique constraint exceptions are caught (very important! if the DB dies, that's not something we can ignore)
3. avoid causing duplicate key issues, when possible

[Ocramius]

Note: no assertions provided here. The assertion is self::once() on the insert call.

[henrikbjorn]

any idea why the tests are failing?

[Ocramius]

Falures are at install/pecl/pyrus. Not stuff that I touched :-\

On 25 Aug 2016 8:39 p.m., "Henrik Bjørnskov" notifications@github.com
wrote:

any idea why the tests are failing?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#252 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakJjIn4IvYp9pnQoK5HIMk4uPi_A3ks5qjeFwgaJpZM4Jp9hE
.

[danydev]

@henrikbjorn what can I do to speed up the merge of this one? As explained on #275 this prevents Bernard to work on PostgreSQL 9.5.x

[henrikbjorn]

Im currently sick so ill look at it, when my head clears up.

[henrikbjorn]

@Ocramius Thanks for this, sorry for me being so slow getting back and merging this.

[Ocramius]

Dude, I have PRs that are pending since 5 years, and you are not paid to do this: no need to be sorry! Thanks for merging!

…

On 15 Dec 2016 9:52 a.m., "Henrik Bjørnskov" ***@***.***> wrote: @Ocramius <https://github.com/Ocramius> Thanks for this, sorry for me being so slow getting back and merging this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#252 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakMJtzkZ5lM0UE-LrWyGn2MdG9gBcks5rIP_OgaJpZM4Jp9hE> .

[danydev]

@henrikbjorn thank you!

[ruudk]

Thanks! You guys are awesome :D

[danydev]

@henrikbjorn sorry to disturb you again, but I'm wondering if you intentionally merged it on 0.x branch. If it is intentional, what's the process to have it merged back on master?

[henrikbjorn]

@danydev you are a life saver, didn't even notice. I have merged it into the master branch as well.

[danydev]

@henrikbjorn ahah you're welcome but I don't see it on master yet

[danydev]

@henrikbjorn ping :-)

[asprega]

Hi @henrikbjorn ! We could really use this fix on master, even better if in a new tagged release. Are you able to merge this to master or are there any issues?