Survivalist Exosuit #73
Conversation
...main/java/software/bernie/techarium/client/item/armor/render/SurvivalistExosuitRenderer.java
Show resolved
Hide resolved
| @@ -32,9 +32,21 @@ public void addTranslation(TranslationLangEntry text, String name) { | |||
| add(text.get().getKey(), name); | |||
| } | |||
|
|
|||
| public void addDescription(TranslationLangEntry text, String name) { | |||
There was a problem hiding this comment.
name -> description
| "itemGroup.techarium": "Techarium", | ||
| "shift.techarium.description": "Hold [LShift] for description", | ||
| "shift.techarium.description": "\u00A76\u00A76Hold \u00A7b[LShift] \u00A76for a description", |
There was a problem hiding this comment.
see TechariumLangProvider
| addDescription(LangRegistry.botariumDescription, "The Botarium allows you to grow crops in exchange for energy and a suitable fluid"); | ||
| addDescription(LangRegistry.arboretumDescription, "The Arboretum allows you to grow saplings in exchange for energy and water"); | ||
| addDescription(LangRegistry.exchangeDescription, "The Exchange Station allows you to unlock new machines with gold"); | ||
| addDescription(LangRegistry.machineShiftDescription, "&6Hold &b[LShift] &6for a description"); |
There was a problem hiding this comment.
| addDescription(LangRegistry.machineShiftDescription, "&6Hold &b[LShift] &6for a description"); | |
| addDescription(LangRegistry.machineShiftDescription, "Hold &b[LShift] &6for a description"); |
Not neccasary &6 at start
and rename to shiftDescription
| return (Ingredient) this.repairMaterial.get(); | ||
| } | ||
|
|
||
| @OnlyIn(Dist.CLIENT) |
There was a problem hiding this comment.
| @OnlyIn(Dist.CLIENT) |
Remove OnlyIn. This method is safe to call on server.
This is generally meant for internal Forge and FML use only and modders should avoid its use whenever possible.-JavaDoc of OnlyIn
| this.repairMaterial = new LazyValue(repairMaterialSupplier); | ||
| } | ||
|
|
||
| public int getDurabilityForSlot(EquipmentSlotType slotIn) { |
There was a problem hiding this comment.
add @OverRide to all methods
| if (ArmorUtil.isWearingAll(player, SurvivalistExosuitItem.class)) { | ||
| Utils.addEffect(player, speedBoost); | ||
| Utils.addEffect(player, hasteBoost); | ||
| } else { | ||
| Utils.removeEffect(player, speedBoost); | ||
| Utils.removeEffect(player, hasteBoost); | ||
| } |
There was a problem hiding this comment.
This does not work for entites like zombies or villagers but I don't know how to fix that in a good way.
If the player uses shift+delete button in creative or /clear inventory the potion effects stay since the Armor doesn't tick where not all pieces are worn. Maybe move this code to a PlayerTickEvent-Listener with a check for Phase START or END(I would use END)
There was a problem hiding this comment.
I suggest using LivingEquipmentChangeEvent that should work for all other entities aswell and since the effect is permanent it doesn't need to be reapplied every tick
| protected final LazyValue<Ingredient> repairMaterial; | ||
|
|
||
| public TechariumArmorMaterial(String nameIn, int maxDamageFactorIn, int[] damageReductionAmountsIn, int enchantabilityIn, SoundEvent equipSoundIn, float toughnessIn, float knockbackResistanceIn, Supplier<Ingredient> repairMaterialSupplier) { | ||
| this.name = nameIn; |
There was a problem hiding this comment.
you don't need In behind every parameter because you already use this. for everything.
This PR: