Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Can't Update manifest after wrong nodepool definition #1483

Open
Despire opened this issue Aug 28, 2024 · 0 comments · May be fixed by #1566
Open

Bug: Can't Update manifest after wrong nodepool definition #1483

Despire opened this issue Aug 28, 2024 · 0 comments · May be fixed by #1566
Assignees
Labels
bug Something isn't working groomed Task that everybody agrees to pass the gatekeeper

Comments

@Despire
Copy link
Contributor

Despire commented Aug 28, 2024

Current Behaviour

If I provide a wrong nodepool definition

      - name: htz1
        providerSpec:
          name: hetzner-1
          region: nbg1
          zone: nbg1-dc3
        count: 1
        serverType: cpx113
        image: ubuntu-22.04
        storageDiskSize: 50

Note the serverType cpx113 (which doesn't exists) when I try to delete this nodepool and replace it with a correct one (since nodepools are immutable) the current state stored in the db will still hold this wrong value and the updated input manifest with the new nodepool will fail.

Expected Behaviour

The Update should handle the above described case.

Steps To Reproduce

  1. create wrong nodepool
      - name: htz1
        providerSpec:
          name: hetzner-1
          region: nbg1
          zone: nbg1-dc3
        count: 1
        serverType: cpx113
        image: ubuntu-22.04
        storageDiskSize: 50

  1. Replace with correct nodepool
      - name: htz2
        providerSpec:
          name: hetzner-1
          region: nbg1
          zone: nbg1-dc3
        count: 1
        serverType: cpx11
        image: ubuntu-22.04
        storageDiskSize: 50

  1. See the update will fail

Anything else to note

@Despire Despire added the bug Something isn't working label Aug 28, 2024
@Despire Despire added the groomed Task that everybody agrees to pass the gatekeeper label Sep 13, 2024
@Despire Despire self-assigned this Oct 21, 2024
@Despire Despire linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working groomed Task that everybody agrees to pass the gatekeeper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant