fix: malformed terraform state #1566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # manifests/claudie/kustomization.yaml # manifests/testing-framework/kustomization.yaml # manifests/testing-framework/testing-framework.yaml # services/ansibler/server/domain/usecases/update_no_proxy_envs.go # services/ansibler/server/utils/loadbalancers.go
JKBGIT1
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1483
closes #1275
This PR introduces changes as to how errors in building infrastructure is handled in terraformer.
There are essentially 3 cases that needs to be taken care of.
This PR fixes these cases as follows:
If there is an error in building the nodepools of the desired state after an unsucessful terraform apply the state file is dumped and any partially build state that was not part of the state file before the terraform apply is destroyed, essentially performing a infrastructure rollback to the last working state. After an error occurs during terraform apply the current state is left as is and is not updated, thus avoiding conflicts as described in issue #1483