Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Issue 3402) Add work-around for iOS 7 Safari bug impacting bootstrap modal #23

Closed
wants to merge 3 commits into from

Conversation

mrvisser
Copy link

Turns out this is a bug in iOS 7 Safari: twbs/bootstrap#9023

Basically Safari is not updating the position of fixed elements after it expands / collapses the keyboard (or other items such as the tool bar).

I've resolved this issue by using a posted work around, which tests to work well, though is a bit of a hack. I'm not aware of any better solutions to the problem.

@bertpareyn
Copy link
Owner

This looks good, since we will remove the patch after bootstrap fixes it it can probably stay in the bootstrap.focus js.

@bertpareyn
Copy link
Owner

This introduces another issue where the modal doesn't take full width on the iPad.
image

@mrvisser
Copy link
Author

This also has the opposite effect on iphone. I'll investigate.

@mrvisser
Copy link
Author

mrvisser commented Feb 4, 2014

@BP323 Did an iteration on this:

  • Removed the CSS being set in the workaround that set a top-margin on the body and made it absolute. That absolute positioning I believe contributes to the modal falling out of the scope of the modal backdrop in your screenshot
  • Set initial / maximum zoom meta data. This should avoid zooming when the modal wants to be bigger than the page (saw that on iPhone), and also doesn't fudge with the viewport zoom when switching orientation, this appears like it may be having an effect in your screenshot (Did you switch from vertical orientation to horizontal orientation in that screenshot, by any chance?)

This fixes similar issues on iPhone that seem to appear in your screenshot. I don't have an iPad to test with, so can you give this a whirl? The branch is available on QA2 at the moment

@bertpareyn
Copy link
Owner

Closing in favor of oaeproject#3512

bertpareyn pushed a commit that referenced this pull request Sep 25, 2014
Added leading zero's to identifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants