Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick PRs for HasByName, etc. and fix GeyByAddress error type #5

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

jefft0
Copy link

@jefft0 jefft0 commented Oct 30, 2023

The branch with-gno-PRs has been rebased to the latest gnolang/gno master branch. This PR is against the branch with-gno-PRs. Cherry pick gnolang#1313 and gnolang#1316 .

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91659e5) 30.75% compared to head (bcb1dd9) 29.33%.
Report is 16 commits behind head on with-gno-PRs.

Additional details and impacted files
@@               Coverage Diff                @@
##           with-gno-PRs       #5      +/-   ##
================================================
- Coverage         30.75%   29.33%   -1.42%     
================================================
  Files                82       69      -13     
  Lines             27666    26082    -1584     
================================================
- Hits               8508     7652     -856     
+ Misses            18325    17646     -679     
+ Partials            833      784      -49     
Files Coverage Δ
gnovm/cmd/gno/lint.go 84.21% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@D4ryl00
Copy link

D4ryl00 commented Oct 30, 2023

I changed your title because Chore should be chore (lowercase).
image

@D4ryl00 D4ryl00 changed the title Chore: Cherry pick PRs for HasByName, etc. and fix GeyByAddress error type chore: Cherry pick PRs for HasByName, etc. and fix GeyByAddress error type Oct 30, 2023
@jefft0 jefft0 merged commit 1f680a2 into with-gno-PRs Oct 30, 2023
70 of 71 checks passed
@jefft0 jefft0 deleted the chore/cherry-pick-PRs-1313-and-1316 branch October 30, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants