fix: HasByAddress should take crypto.Address, like GetByAddress #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## with-gno-PRs #6 +/- ##
================================================
+ Coverage 29.33% 30.75% +1.41%
================================================
Files 69 82 +13
Lines 26082 27666 +1584
================================================
+ Hits 7652 8508 +856
- Misses 17646 18325 +679
- Partials 784 833 +49 ☔ View full report in Codecov by Sentry. |
D4ryl00
approved these changes
Oct 30, 2023
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
force-pushed
the
fix/HasByAddress-crypto-Address
branch
from
28b43bc
to
b20bcc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Keybase method
GetByAddresstakes a crypto.Address . PR gnolang#1313 adds more methods, includingHasByAddress, and we did a cherry-pick into the with-gno-PRs branch. However that version ofHasByAddresstakes a bech32Address. But it should also take acrypto.Address. I did a force commit to fix that PR. This PR makes the same changes here in the with-gno-PRs branch.