Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absolute amp-script paths #151

Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix: absolute amp-script paths #151

merged 1 commit into from
Sep 8, 2020

Conversation

cdeleeuwe
Copy link
Collaborator

PR #150 broke the regular site because amp-script does not allow using relative src paths. This PR reverts it back to absolute paths, but when building for IPFS, it uses relative paths

@cdeleeuwe cdeleeuwe requested a review from moul September 8, 2020 11:54
@cdeleeuwe cdeleeuwe requested a review from pierreboc as a code owner September 8, 2020 11:54
@cdeleeuwe cdeleeuwe self-assigned this Sep 8, 2020
@auto-add-label auto-add-label bot added the bug Something isn't working label Sep 8, 2020
@trafico-bot trafico-bot bot added the 🚧 WIP label Sep 8, 2020
@cdeleeuwe cdeleeuwe changed the title WIP fix: absolute amp-script paths fix: absolute amp-script paths Sep 8, 2020
@cdeleeuwe
Copy link
Collaborator Author

@moul this PR is ready for review

@moul moul merged commit 6a35c67 into master Sep 8, 2020
@moul moul deleted the dev/cas/fix_amp_scripts branch September 8, 2020 14:18
@trafico-bot trafico-bot bot added ✨ Merged ✅ Approved Feature request has been approved and removed 🔍 Ready for Review labels Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Approved Feature request has been approved bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants