Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename output to dest for jpackage task #91

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Oct 2, 2019

The latest version of jpackage was just made public and there the --output argument was renamed to --dest. See https://openjdk.java.net/jeps/343. I've not yet tested if these were the only breaking changes. See here for a list of all changes: https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-October/062682.html

@siordache
Copy link
Member

@tobiasdiez Thanks a lot for the PR!

It seems that there is another breaking cnange in this release: the --identifier option was dropped. Can you please check if this is really the case and, if necessary, remove this line?

@DJViking
Copy link
Collaborator

DJViking commented Oct 2, 2019

It seems that there is another breaking cnange in this release: the --identifier option was dropped.

Yes it has been removed from jpackage.

@tobiasdiez
Copy link
Contributor Author

Ok, I've removed it.

@DJViking DJViking merged commit ba2cb46 into beryx:master Oct 2, 2019
@tobiasdiez
Copy link
Contributor Author

Thanks for the quick merge. Is there a way to convinently use the latest snapshot containing this fix?

@siordache
Copy link
Member

Release 2.16.0 contains this PR and an additional small change.

@tobiasdiez @DJViking I only tested on Windows, with two small projects, so please check if it also works on other platforms and with your own projects. Thanks for your help!

@tobiasdiez
Copy link
Contributor Author

Thanks for the release! It's working for us on windows, Mac and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants