remove JsonPathInst, instead move find functionality to JsonPath.
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer export all macros, add comments to the remaining ones. Implement `FromStr` and `TryFrom<&str` for JsonPath (as the internet is not sure which is better) fix various clippy things.
besok
reviewed
Jul 9, 2024
besok
reviewed
Jul 9, 2024
besok
reviewed
Jul 9, 2024
besok
reviewed
Jul 9, 2024
besok
reviewed
Jul 9, 2024
|
Hi @besok I pushed another commit and adjusted the macro exports :) |
|
Great! Thank you for the awesome PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59
This PR has no further performance improvements like the other ones.
However it tries to simplify the usage of the crate for others.
That is done by getting rid of the
JsonPathInstwhich was basically just aJsonPathand moving the independendfindfunctions (3 independent and one in theJsonPathInst) all directly to theJsonPath.Additionally the internal macros which where used for testing are no longer exported (i keep the
jp_vandpathone because I though those might make sense externally, please correct me here if others are used too).This makes the docs page thinner, and focuses users more towards the common usecase:
Most diff is just moving the code, I found it hard to find the right spot for the
JsonPathas its a result of the parser but also defines how stuff is searched and heavily relies on thepath. I just now chosed a own file, though not 100% happy with it either.Oh I could get rid of the
vec_init_then_pushclippy warnings in the macros, shouldn't have a big impact though.