This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Creating new function to push test results after executed with bst CLI #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecruzado
reviewed
Nov 19, 2021
ecruzado
reviewed
Nov 19, 2021
| }, [process.cwd()]); | ||
| const success = returnValue.results ? returnValue.results.success : false; | ||
| return success; | ||
| return jestModule.runCLI({ config, runInBand }, [process.cwd()]) |
There was a problem hiding this comment.
this method has changed the return type of the function, before the change a boolean was the result of the function, now it is a promise. Make sure this change does not break how jest interact with our code
…omerIdFromSource" crashes
ecruzado
approved these changes
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 92.22% 92.17% -0.06%
==========================================
Files 28 30 +2
Lines 2213 2301 +88
Branches 499 497 -2
==========================================
+ Hits 2041 2121 +80
- Misses 159 167 +8
Partials 13 13
Continue to review full report at Codecov.
|
…refactoring request for saving results and getting customer_id
maxbespoken
deleted the
feature-addbespokenresultsintojestresult-by_max
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #492
The code implemented is for a new class to send execution results to "bespoken-api" endpoint.
This new class executes after JEST completes the execution of all suites and it pushes the results to the endpoint.
Environment variable was added for point the "bespoken-api".
Name: BESPOKEN_API_BASE_URL
Default value: https://bespoken-api.bespoken.tools
Also, it was removed the code related to "saveTestResults", "getSourceExists" and its dependencies in the unit tests.