-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context support and reset context #29
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 93.51% 93.68% +0.16%
==========================================
Files 14 14
Lines 447 459 +12
Branches 45 48 +3
==========================================
+ Hits 418 430 +12
Misses 29 29
Continue to review full report at Codecov.
|
src/ActionInteractor.ts
Outdated
this.context = response.outputContexts; | ||
} | ||
|
||
return response; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.context = response.contextOut || response.outputContexts;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a linter that will do these sorts of checks? I know I tend to prefer a more verbose style, but I would mostly just be happy if we had a consistent standard that was applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkelvie added as a ts-lint rule in this repo, we can expand to the next repo's along other agreements.
Relates to #22 and #27