Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context support and reset context #29

Merged
merged 4 commits into from
Jun 27, 2018
Merged

Add context support and reset context #29

merged 4 commits into from
Jun 27, 2018

Conversation

jperata
Copy link
Contributor

@jperata jperata commented Jun 27, 2018

Relates to #22 and #27

@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #29 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   93.51%   93.68%   +0.16%     
==========================================
  Files          14       14              
  Lines         447      459      +12     
  Branches       45       48       +3     
==========================================
+ Hits          418      430      +12     
  Misses         29       29
Impacted Files Coverage Δ
src/VirtualGoogleAssistant.ts 90.32% <100%> (+0.49%) ⬆️
src/ActionInteractor.ts 88.88% <100%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d119bc5...8c9aeb8. Read the comment docs.

this.context = response.outputContexts;
}

return response;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.context = response.contextOut || response.outputContexts;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a linter that will do these sorts of checks? I know I tend to prefer a more verbose style, but I would mostly just be happy if we had a consistent standard that was applied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkelvie added as a ts-lint rule in this repo, we can expand to the next repo's along other agreements.

@jperata jperata merged commit f34a131 into master Jun 27, 2018
@jperata jperata deleted the context branch June 27, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants