222 gridlines on selected sheets #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanhemsi
requested changes
Jun 28, 2024
|
I think a future enhancement would be for users to be able to specify which sheets should have gridlines using a dictionary but I want to get this approach merged in first and leave that for the future |
rowanhemsi
requested changes
Jun 28, 2024
gptables/core/api.py
Outdated
Comment on lines
76
to
79
| if cover_gridlines: | ||
| ws = wb.add_worksheet(cover.cover_label, gridlines=gridlines) | ||
| else: | ||
| ws = wb.add_worksheet(cover.cover_label, gridlines=2) | ||
| ws = wb.add_worksheet(cover.cover_label, gridlines="hide_all") |
There was a problem hiding this comment.
I don't think the if-else is necessary if we specify a default value in the function definition? Does this work if you just have ws = wb.add_worksheet(cover.cover_label, gridlines=gridlines) ?
There was a problem hiding this comment.
The if-else is for when you want gridlines on the workbook but not on the cover sheet specifically.
rowanhemsi
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter in write/produce_workbook to show or hide gridlines on the worksheets and another parameter to choose whether to include the gridlines on the cover worksheet.