Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to spark.shuffle.service.enabled = true #145

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ChrisSoderberg-ONS
Copy link
Contributor

Merge request template: please remove the appropriate parts of this template.

Pre-merge request checklist (to be completed by the one making the request):

  • I have performed a full review of this code myself.
    • For Python code in PySpark specific sections, all code should have been run in Jupyter notebooks.
    • For code in sections of the book containing both Python and R code, the page of the book should be constructed as described in the contributing guide and converted to a markdown file.
  • I have formatted the outputs of code blocks correctly (to match other outputs in the book and in line with the style guide [coming soon])
  • I have built the book as outlined in the contributing guide and confirmed that any additional/modified content is displaying as expected.

Details of this request (such as):

  • Removed references to spark.shuffle.service.enabled = true due to complaints from users as this configuration must be disabled when using Spark on Cloudera Machine Learning

Requirements for review (such as):

  • Review markdown edits
  • Build book

@emercado4 emercado4 self-requested a review October 24, 2024 13:29
Copy link
Contributor

@emercado4 emercado4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris, changes made all look good and I can't find any other references to spark.shuffle.service.enabled = true so I think this is ready to merge in.

@emercado4 emercado4 marked this pull request as ready for review October 24, 2024 14:12
@emercado4 emercado4 merged commit f75b0cc into main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants