Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Breaking change was introduced in 1.3.1 ~> 1.3.2 patch release #112

Closed
mbixby opened this issue Nov 7, 2016 · 2 comments
Closed

Breaking change was introduced in 1.3.1 ~> 1.3.2 patch release #112

mbixby opened this issue Nov 7, 2016 · 2 comments
Labels
bug

Comments

@mbixby
Copy link

mbixby commented Nov 7, 2016 •
edited
Loading

'Place more common consumer Windows OS names before Windows Server names' changed titles for some versions of Windows (e.g. 'Server 2008 R2 / 7 ~> 7 / Server 2008 R2). This was public API and some people were using it for comparisons (based on other tickets here).

The previous values should be reverted in the next patch release (1.3.3), breaking change should increment major version.
@bnjmnt4n
Copy link
Member

bnjmnt4n commented Nov 9, 2016

Seems like there's another breaking change in d6e64f1. I'll try to do a patch release tomorrow. Sorry for not taking SemVer into consideration, I guess I'll shift those into v2.0.

@bnjmnt4n bnjmnt4n added the bug label Nov 9, 2016
bnjmnt4n added a commit that referenced this issue Nov 10, 2016
@bnjmnt4n
Revert "Place more common consumer Windows OS names before Windows Se…
3d23631 
…rver names."

This reverts commit ccf08e2.
Ref. #112.
@bnjmnt4n
Copy link
Member

I've tagged v1.3.3, which has commit 3d23631, reverting the changes from 6d17ca2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbixby @bnjmnt4n